SEA: support primitive params #612
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
varun-edachali-dbx
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
varun-edachali-dbx
requested review from
deeksha-db,
gopalldb,
jackyhu-db,
jayantsing-db,
jprakash-db,
madhav-db,
samikshya-db,
shivam2680 and
vikrantpuppala
as code owners
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
varun-edachali-dbx
had a problem deploying
to
azure-prod
GitHub Actions
Failure
varun-edachali-dbx
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
varun-edachali-dbx
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
varun-edachali-dbx
changed the title
ttypes.TSparkParameter to re-use existing parameter processing
varun-edachali-dbx
removed request for
deeksha-db,
gopalldb,
jackyhu-db,
jprakash-db,
madhav-db,
samikshya-db and
shivam2680
varun-edachali-dbx
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Earlier,
execute_commandinSeaDatabricksClientwas expecting aList[Dict[str, Any]], with the intention of implementing parameter processing later and converting them into a simpleList[Dict]to be consumed by the SEA backend.But, this does not align with the current code which passes a
List[ttypes.TSparkParameter]. Also, re-using this Thrift parameter object allows us to re-use the existing parameter processing completely.How is this tested?
"use_sea": Truein theconnection paramsRelated Tickets & Documents
N/A